BIP68: fix wrong upper bound for nHeight#2178
Open
pythcoiner wants to merge 1 commit into
Open
Conversation
Author
jonatack
added
the
Fixups
darosior
approved these changes
May 28, 2026
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
The comment was indeed incorrect, and your change makes it matches what the snippet actually implements (nSequence & 0x0000ffff).
darosior
approved these changes
May 28, 2026
murchandamus
approved these changes
May 28, 2026
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
LGTM, will merge tomorrow unless new information suggests otherwise.
jonatack
reviewed
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
65_535 is a valid value for
nHeight, see bitcoin-core code here, here and here.