fix: swap scriptPathControlBlocks[1] and [2] for three-leaf P2MR test vectors#2102
Open
jasonandjay wants to merge 1 commit intobitcoin:masterfrom
Open
Conversation
… vectors In a tree structured as [leaf0, [leaf1, leaf2]], the control block for spending a leaf must contain the sibling hashes along the Merkle path, not the leaf's own hash. The current test vectors have the control blocks for leaf1 and leaf2 swapped, causing them to include the spending leaf's own hash as the first path element instead of its sibling's hash. Fix swapped scriptPathControlBlocks entries for: - p2mr_three_leaf_complex - p2mr_three_leaf_alternative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
In a tree structured as [leaf0, [leaf1, leaf2]],
the control block for spending
a leaf must contain the sibling
hashes along the Merkle path, not the leaf's
own hash. The current test vectors have the control blocks for leaf1 and leaf2
swapped, causing them to include the spending leaf's own hash as the first path
element instead of its sibling's hash.
Example:es 1 and 2 in the
three-lea
Intermediate leaf hashes (correct in the test vector):
Fix swapped
Fix
Swap1 and 2 in the
three-leaf P2MRand scriptPathControlBlocks[2]:
Verification of correctedontrolBlocks
The same issue exists in P2MR test vectors
p2mr_threeandis fixed identically.