-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Replace BIP 77 mermaid diagrams with ascii diagrams #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Updated sequence diagrams to use text format instead of mermaid syntax. I cargo cult'd the RFC Rules: > “How are images handled for the plain text version of an RFC?” > The RFC Editor will accept both ASCII art and SVG. If only ASCII art is provided, it will be included in all publication formats. If ASCII art and SVG are both provided, ASCII art will be included in the plain text, and SVG in all other outputs. A note indicating alternative artwork is available is strongly advised. If only SVG is provided, a URI will be included in the plain-text publication format pointing to the HTML version. All artwork and figures should have a complete written description to support assisted reader technology. see: https://www.rfc-editor.org/rse/format-faq/ Since BIPs don't publish html/pdf renders, ASCII art seems like the right choice to render everywhere. Since normative prose is already provided, I chose not to include a written description of the diagrams to support assisted reader tech.
|
Rather than downgrading to ascii art, maybe include the mermaid source in a bip-0077 directory and generate an svg from it (either using mermaid-cli or copy/pasting into the live editor and exporting?) At the very least, mermaid source is easier to edit than ascii art. |
|
This was something we bikeshedded even in the original PR and is not the most consequential. I am revisiting only because of a request. ascii art is about as simple as possible, and these diagrams are ancient at this point and really don't need to change. LLMs will produce ascii art from mermaid source, which is now in the commit history. I'd like to go ahead with this as-is for simplicity unless there's a really really good reason to change again. |
|
I'm not sure when the unanimous agreement on @ajtowns 's suggestion came through via "👍" because I don't get notified by emojis. I would have addressed this earlier if someone reinforced that my prior approach was unacceptable by comment. Should be good to go now. |
16d67a5 to
0bc0550
Compare
|
(non blocking comment) I liked the ascii art better. The svg is not sized correctly and doesn't have a transparent background for those of us using dark mode. Also I can't figure out which settings I had turned on that caused the rendering issue in the first place. |
|
sizing is fixable in github with progressive css (is that really what we want here) but transparent background likely won't work because I'd have to use custom theme to render the svg with diagram lines that look ok on every possible background. This is major bikeshedding. ASCII "just works" all the time and you can really tell a free LLM "add this line" "remove x part" these days. editing ascii art is a non-issue in 2026. |
|
Ok after discussing with Ava I pushed the mermaid stuff here if you really want to look, but I promise it's a bigger pain in the hiney https://github.com/DanGould/bips/commits/mermaid-bip77/ I guess everyone just checked out for the holidays like myself. I'm re force-pushing ascii art to the pr and would appreciate a simple go-ahead as the original author editing his own bip with identical content in a different format. Thank you for your attention to this matter. |
Updated sequence diagrams to use text format instead of mermaid syntax responding to @achow101's comment
I cargo cult'd the RFC Rules:
see: https://www.rfc-editor.org/rse/format-faq/
Since BIPs don't publish html/pdf renders, ASCII art seems like the right choice to render everywhere. Since normative prose is already provided, I chose not to include a written description of the diagrams to support assisted reader tech.
cc @nothingmuch