qt: Add "Hide conflicted" checkbox to Transactions tab#925
qt: Add "Hide conflicted" checkbox to Transactions tab#925w0xlt wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
Add a "Hide conflicted" checkbox to the Transactions tab filter row, allowing users to hide conflicted transactions from the transaction list. This reuses the existing TransactionFilterProxy::setShowInactive() functionality that was already used by the Overview page.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
|
Approach NACK. "Conflicted" should be reduced to an implementation detail IMO. Instead, I suggest hiding conflicted transactions by default after N blocks, and have an advanced setting (in the settings dialog?) to show them. |
pablomartin4btc
left a comment
pablomartin4btc
left a comment
There was a problem hiding this comment.
Concept ACK
One thought: perhaps the Hide button should only appear when there are actually conflicted transactions present.
Alternatively, if Luke’s approach is preferred, it might be worth adding some visual indication (e.g. a label or status message) that conflicted transactions exist, or enabling a button/action to view them in a separate window.
Finally, if feasible, it would be great to include brief test instructions in the PR description, outlining how to verify the behavior before and after the change.
4 participants
Conflicted transactions can accumulate in the wallet over time. These transactions clutter the transaction list and cannot be filtered out.
While the Overview page already hides conflicted transactions using
TransactionFilterProxy::setShowInactive(false), the Transactions tab has no equivalent option, forcing users to scroll through potentially many obsolete entries.This PR adds a "Hide conflicted" checkbox to the Transactions tab filter row, allowing users to toggle visibility of conflicted transactions. The implementation reuses the existing
setShowInactive()function.Before:
Users must manually scroll past conflicted transactions with no filtering option.
After:
A checkbox in the filter row lets users hide conflicted transactions with one click.