bond: fix race conditions and improve test coverage#22
Open
dnldd wants to merge 1 commit intobisoncraft:masterfrom
Open
bond: fix race conditions and improve test coverage#22dnldd wants to merge 1 commit intobisoncraft:masterfrom
dnldd wants to merge 1 commit intobisoncraft:masterfrom
Conversation
Contributor
dnldd
commented
Mar 18, 2026
dnldd
commented
- Fix time-of-check, time-of-use race condition in RemoveBondAtIndex by holding write lock for entire operation
- Fix data race in PostBondReqFromBondInfo by holding read lock during slice iteration
- Fix incomplete cleanup in RemoveBondAtIndex: properly update totalStrength and storedBonds (enables bond re-addition)
- Add comprehensive edge case tests covering empty bonds, expired bonds, duplicate rejection, and boundary conditions
- Add concurrent tests verifying race-free behavior under multiple simultaneous operations on RemoveBondAtIndex
- Add concurrent tests for PostBondReqFromBondInfo validating safe reads during concurrent modifications
- Add cleanup verification tests ensuring removed bonds can be re-added without state corruption
- Increase test coverage from 88.5% to 98.1% with 11 new tests covering concurrency, cleanup, and edge cases
- Fix time-of-check, time-of-use race condition in RemoveBondAtIndex by holding write lock for entire operation - Fix data race in PostBondReqFromBondInfo by holding read lock during slice iteration - Fix incomplete cleanup in RemoveBondAtIndex: properly update totalStrength and storedBonds (enables bond re-addition) - Add comprehensive edge case tests covering empty bonds, expired bonds, duplicate rejection, and boundary conditions - Add concurrent tests verifying race-free behavior under multiple simultaneous operations on RemoveBondAtIndex - Add concurrent tests for PostBondReqFromBondInfo validating safe reads during concurrent modifications - Add cleanup verification tests ensuring removed bonds can be re-added without state corruption - Increase test coverage from 88.5% to 98.1% with 11 new tests covering concurrency, cleanup, and edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.