oracle: improve test coverage and fix issues#21
Open
dnldd wants to merge 1 commit intobisoncraft:masterfrom
Open
oracle: improve test coverage and fix issues#21dnldd wants to merge 1 commit intobisoncraft:masterfrom
dnldd wants to merge 1 commit intobisoncraft:masterfrom
Conversation
Contributor
dnldd
commented
Mar 18, 2026
dnldd
commented
- Fix potential goroutine accumulation in diviner.publishUpdate by removing async fire-and-forget (would manifest under publish failures)
- Extract fetchUpdatesTimeout constant (30s) for explicit fetch deadline management
- Add context timeout to fetchUpdates to prevent indefinite blocking
- Pass logger to fetchTracker for proper error reporting during ID space exhaustion
- Enhance provider tests to verify meaningful quota tracking behavior (not just nil checks)
- Add HTTP utility tests (http_test.go) for DoGet and StreamDecodeJSON covering error cases, edge cases
- Implement comprehensive source provider tests (bitcore, firo, coingecko pro) with proper mocking
- Replace shallow structure-existence tests with behavioral assertions (quota limits, consumption tracking)
- Add TatumQuotaFetcher error propagation test validating HTTP errors are handled correctly
- Improve CoinMarketCap and Tatum quota tests to verify tracking is enabled and values are meaningful
- Fix potential goroutine accumulation in diviner.publishUpdate by removing async fire-and-forget (would manifest under publish failures) - Extract fetchUpdatesTimeout constant (30s) for explicit fetch deadline management - Add context timeout to fetchUpdates to prevent indefinite blocking - Pass logger to fetchTracker for proper error reporting during ID space exhaustion - Enhance provider tests to verify meaningful quota tracking behavior (not just nil checks) - Add HTTP utility tests (http_test.go) for DoGet and StreamDecodeJSON covering error cases, edge cases - Implement comprehensive source provider tests (bitcore, firo, coingecko pro) with proper mocking - Replace shallow structure-existence tests with behavioral assertions (quota limits, consumption tracking) - Add TatumQuotaFetcher error propagation test validating HTTP errors are handled correctly - Improve CoinMarketCap and Tatum quota tests to verify tracking is enabled and values are meaningful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.