Port the existing code - without quizzes, users and admin#1
Closed
janezd wants to merge 1 commit intobiolab:masterfrom
Closed
Port the existing code - without quizzes, users and admin#1janezd wants to merge 1 commit intobiolab:masterfrom
janezd wants to merge 1 commit intobiolab:masterfrom
Conversation
…s and user login; the corresponding code is commented out. Quiz-related props still exist, but they're unused, and dummy values are used in some places. The directory public is empty (except for collection.md) and will stay this way. For the time being, symlink the existing `books` directory into `public`. The code uses the latest versions of dependencies, except for tailwind, for which I had to downgrade to version 3 after spending a few hours trying to mediate the fight between tailwind and sass. As a result of this fight, CSS's are reorganized a bit, which may be unnecessary. React code is changed in a few places. The two I remember (and which may be the only two overal) are: - React.ReactNode must be used in instead of JSX.Element - useRef now requires initial value and type (if initial value is null). This code survives `yarn build` and the rendering looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of existing code, excluding anything related to quizzes and user login;
the corresponding code is commented out. Quiz-related props still exist, but they're unused, and dummy values are used in some places.
The directory public is empty (except for collection.md) and will stay this way. For the time being, symlink the existing
booksdirectory intopublic.The code uses the latest versions of dependencies, except for tailwind, for which I had to downgrade to version 3 after spending a few hours trying to mediate the fight between tailwind and sass. As a result of this fight, CSS's are reorganized a bit, which may be unnecessary.
React code is changed in a few places. The two I remember (and which may be the only two overal) are:
This code survives
yarn buildand the rendering looks correct.