Skip to content

Conversation

@buaazyl
Copy link
Contributor

@buaazyl buaazyl commented Jan 6, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

此 PR 修复了当未配置 HTTP 代理密码时,使用 HttpComponents 客户端实现会导致启动报错的问题。通过在调用 toCharArray() 方法前添加空值检查,避免了 NullPointerException

主要变更:

  • 在 6 个 HttpComponents 服务实现类的 initHttp() 方法中添加空值检查
  • 移除了 2 个未使用的 import 语句

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
weixin-java-qidian/src/main/java/me/chanjar/weixin/qidian/api/impl/WxQidianServiceHttpComponentsImpl.java 添加 httpProxyPassword 空值检查以防止启动时 NPE
weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpServiceHttpComponentsImpl.java 添加 httpProxyPassword 空值检查以防止启动时 NPE
weixin-java-cp/src/main/java/me/chanjar/weixin/cp/tp/service/impl/WxCpTpServiceHttpComponentsImpl.java 添加 httpProxyPassword 空值检查并移除未使用的 import
weixin-java-cp/src/main/java/me/chanjar/weixin/cp/corpgroup/service/impl/WxCpCgServiceHttpComponentsImpl.java 添加 httpProxyPassword 空值检查以防止启动时 NPE
weixin-java-cp/src/main/java/me/chanjar/weixin/cp/api/impl/WxCpServiceHttpComponentsImpl.java 添加 httpProxyPassword 空值检查以防止启动时 NPE
weixin-java-channel/src/main/java/me/chanjar/weixin/channel/api/impl/WxChannelServiceHttpComponentsImpl.java 添加 httpProxyPassword 空值检查并移除未使用的 import

@binarywang
Copy link
Owner

auggie review

@augmentcode
Copy link

augmentcode bot commented Jan 6, 2026

🤖 Augment PR Summary

Summary:
Prevents a startup NullPointerException in initHttp() when using HttpComponents with proxy password left unset.

Changes:
Updates Channel/CP/MP/Qidian HttpComponents service implementations to pass a null-safe proxy password (and removes a couple of unused imports).

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@binarywang binarywang merged commit 9870012 into binarywang:develop Jan 6, 2026
6 checks passed
@binarywang binarywang added this to the 4.8.1 milestone Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants