PROMO-1368 update API to use coupon_overrides_other_promotions #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-vincent-zhao
previously approved these changes
Dec 24, 2025
bc-waynewu
previously approved these changes
Dec 24, 2025
YevenLourance
dismissed stale reviews from bc-waynewu and bc-vincent-zhao
via
a49358e
YevenLourance
force-pushed
the
PROMO-1368
branch
5 times, most recently
from
5f1660d to
8ae5905
Compare
YevenLourance
force-pushed
the
PROMO-1368
branch
2 times, most recently
from
1eccf0d to
eb245bb
Compare
YevenLourance
force-pushed
the
PROMO-1368
branch
2 times, most recently
from
1bfc3d8 to
e9f32d9
Compare
YevenLourance
force-pushed
the
PROMO-1368
branch
3 times, most recently
from
9089882 to
9f61d12
Compare
reference/promotions.v3.yml
Outdated
| schema: | ||
| $ref: '#/components/schemas/ErrorResponse' | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
this extra line probably not needed
denis-bc
reviewed
Jan 15, 2026
reference/promotions.v3.yml
Outdated
| count, | ||
| per_page, | ||
| links | ||
| ] |
There was a problem hiding this comment.
🍹
I'm not aware of this specific syntax for list, does it work?
Commonly multiple lines list is defined with dashes:
required:
- count
- per_page
- links
denis-bc
previously approved these changes
Jan 15, 2026
reference/promotions.v3.yml
Outdated
Comment on lines
588
to
590
| type: boolean | ||
| example: false | ||
| default: false |
Contributor
There was a problem hiding this comment.
the extra empty space probably not needed
reference/promotions.v3.yml
Outdated
| - CHECKOUT_PAGE | ||
| items: | ||
| type: string | ||
| type: string |
Contributor
There was a problem hiding this comment.
also don't need the extra empty spaces
| codes: | ||
| $ref: '#/components/schemas/CouponCode' |
YevenLourance
dismissed stale reviews from donald-nguyen-bc and denis-bc
via
267cc06
YevenLourance
force-pushed
the
PROMO-1368
branch
2 times, most recently
from
267cc06 to
7670ec9
Compare
update to coupon_overrides_other_promotions
YevenLourance
force-pushed
the
PROMO-1368
branch
from
7670ec9 to
6e79918
Compare
donald-nguyen-bc
approved these changes
Jan 15, 2026
denis-bc
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROMO-1369
What changed?
update API to use coupon_overrides_other_promotions in requests when create or update promotions
deprecate coupon_overrides_automatic_when_offering_higher_discounts
Release notes draft
Anything else?
ping @bigcommerce/team-promotions