fix(core): strip trailing slash when looking up localized Makeswift page#2950
Open
agurtovoy wants to merge 1 commit intointegrations/makeswiftfrom
Conversation
fixes locale switcher issue when running with TRAILING_SLASH=true
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3535b24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
agurtovoy
commented
Mar 24, 2026
| targetLocale: string; | ||
| }) { | ||
| // Makeswift page pathnames are always stored without a trailing slash | ||
| const pathname = stripTrailingSlash(inputPathname); |
Contributor
Author
There was a problem hiding this comment.
Normalize the pathname before looking it up.
chanceaclark
approved these changes
Mar 24, 2026
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
jorgemoya
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Fix 404 on switching between localized Makeswift pages with locale-specific paths when running with
TRAILING_SLASH=true.Testing
Before:
Kapture.2026-03-23.at.18.30.06.mp4
After:
Kapture.2026-03-24.at.12.15.15.mp4
Migration
N/A