-
Notifications
You must be signed in to change notification settings - Fork 350
chore(catalyst): CATALYST-1297 Run E2E tests on PRs #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jordanarldt
wants to merge
2
commits into
canary
Choose a base branch
from
CATALYST-1297
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c694fd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c8b3c91 to
1734c76
Compare
dd40301 to
16d78ef
Compare
16d78ef to
b96c61a
Compare
b96c61a to
83ba600
Compare
83ba600 to
abd05fc
Compare
abd05fc to
08cb116
Compare
08cb116 to
bbe4811
Compare
bbe4811 to
31fbf0c
Compare
31fbf0c to
3127077
Compare
3127077 to
2e09c1b
Compare
2e09c1b to
5efeb89
Compare
5efeb89 to
b3efeac
Compare
b3efeac to
8d31c4d
Compare
8a28e97 to
f0ed6f7
Compare
f0ed6f7 to
d603c10
Compare
d603c10 to
2035738
Compare
2035738 to
59a7cf3
Compare
59a7cf3 to
dd15d57
Compare
dd15d57 to
f140c44
Compare
f140c44 to
60dec77
Compare
60dec77 to
954ae17
Compare
954ae17 to
f332816
Compare
f332816 to
848ef51
Compare
848ef51 to
c77b89f
Compare
c77b89f to
c694fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Ensure Catalyst E2E tests are executed on pull requests. This will help prevent further breaking changes from contributions. There are 3 separate jobs:
E2E Functional Tests- Executes all e2e testsE2E Functional Tests (alternate locale)- Executes all tests that require an alternate locale to be usedE2E Functional Tests (TRAILING_SLASH=false)- Executes the functional tests that require theTRAILING_SLASHenv var to be disabled. This will prevent 301 redirect loop regressionsTesting
Test suites executed on this PR and they are passing.
Migration
Add
requiredprop to the Country selector and Country input fields incore/vibes/soul/sections/cart/shipping-form/index.tsxon lines 280 and 28For all other changes, use this PR as a reference.