feat(actions-bar): add color property to ActionsBarButton#253
Merged
antobinary merged 1 commit intobigbluebutton:v0.0.xfrom Apr 2, 2026
Merged
Conversation
Add an optional `color` property to `ActionsBarButtonProps` and `ActionsBarButton`, defaulting to 'primary'. This allows plugins to specify button color variants (e.g., 'default' for a neutral button). Companion change to bigbluebutton/bigbluebutton#24719, which reads `plugin.color` in the HTML5 client's actions bar rendering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance! |
3 tasks
GuiLeme
approved these changes
Apr 2, 2026
Collaborator
GuiLeme
left a comment
There was a problem hiding this comment.
demo-actions-bar-color-change.mp4
Reviewed the code tested it locally, it looks good. Now we wait for the merge of this PR and after this is merged we update the SDK version so we can use it in the PR from the core. Thanks for the contribution, @BrentBaccala.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorproperty toActionsBarButtonPropsandActionsBarButton'primary'for backward compatibilitytextColorinUserListDropdownInformationandbackgroundColorinFloatingWindowMotivation
Companion change to bigbluebutton/bigbluebutton#24719, which reads
plugin.colorin the HTML5 client's actions bar rendering. Without this SDK change, plugins must cast toanyto set the color property.Use case: a remote desktop plugin uses button color to indicate lock/unlock state — blue (
'primary') when unlocked, neutral ('default') when locked.Test plan
colorshould be unaffected (defaults to'primary')color: 'default'should pass the value through to the HTML5 clientThis PR was researched and written by an AI assistant (Claude) on behalf of Brent Baccala (cosine@freesoft.org), based on a review request from @GuiLeme on bigbluebutton/bigbluebutton#24719.