Skip to content

Conversation

@donquixote
Copy link

That parameter is always '' as correctly pointed out by my IDE.
It's a private method, so...

(This is baseline for further changes)

@GhaziTriki GhaziTriki self-requested a review March 28, 2025 17:31
@GhaziTriki
Copy link
Member

payload is still used in sendRequest. Is it related to the draft PR injecting custom HTTP client?

@donquixote
Copy link
Author

payload is still used in sendRequest. Is it related to the draft PR injecting custom HTTP client?

The point is: This is a private method, and in every call the $payload is empty string / default value.
So we can drop the parameter and always pass empty string / rely on the default for ->sendRequest().

@donquixote donquixote force-pushed the simplify-processJsonResponse branch from 92c3bd0 to fdcfe59 Compare April 1, 2025 11:15
@GhaziTriki GhaziTriki added this to the 3.0.0 milestone Apr 3, 2025
@GhaziTriki GhaziTriki merged commit 74a9674 into bigbluebutton:develop Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants