Improve parameter constructors

src/BigBlueButton.php

@@ -302,11 +302,9 @@ public function getRecordingsUrl(GetRecordingsParameters $recordingsParams): str
     }
 
     /**
-     * @param mixed $recordingParams
-     *
      * @throws BadResponseException|\RuntimeException
      */
-    public function getRecordings($recordingParams): GetRecordingsResponse
+    public function getRecordings(GetRecordingsParameters $recordingParams): GetRecordingsResponse
     {
         $xml = $this->processXmlResponse($this->getUrlBuilder()->getRecordingsUrl($recordingParams));
 
@@ -414,11 +412,9 @@ public function getHooksCreateUrl(HooksCreateParameters $hookCreateParams): stri
     }
 
     /**
-     * @param mixed $hookCreateParams
-     *
      * @throws BadResponseException
      */
-    public function hooksCreate($hookCreateParams): HooksCreateResponse
+    public function hooksCreate(HooksCreateParameters $hookCreateParams): HooksCreateResponse
     {
         $xml = $this->processXmlResponse($this->getUrlBuilder()->getHooksCreateUrl($hookCreateParams));
 
@@ -452,11 +448,9 @@ public function getHooksDestroyUrl(HooksDestroyParameters $hooksDestroyParams):
     }
 
     /**
-     * @param mixed $hooksDestroyParams
-     *
      * @throws BadResponseException
      */
-    public function hooksDestroy($hooksDestroyParams): HooksDestroyResponse
+    public function hooksDestroy(HooksDestroyParameters $hooksDestroyParams): HooksDestroyResponse
     {
         $xml = $this->processXmlResponse($this->getUrlBuilder()->getHooksDestroyUrl($hooksDestroyParams));
 

src/Core/Track.php

@@ -35,10 +35,7 @@ class Track
 
     private string $source;
 
-    /**
-     * @param mixed $track
-     */
-    public function __construct($track)
+    public function __construct(mixed $track)
     {
         $this->href   = $track->href;
         $this->kind   = $track->kind;

src/Parameters/CreateMeetingParameters.php

@@ -29,9 +29,9 @@ class CreateMeetingParameters extends MetaParameters
 {
     use DocumentableTrait;
 
-    private ?string $meetingId = null;
+    private string $meetingId;
 
-    private ?string $meetingName = null;
+    private string $meetingName;
 
     /**
      * @deprecated Password-string replaced by an Enum\Role-constant in JoinMeetingParameters::__construct()
@@ -183,11 +183,8 @@ class CreateMeetingParameters extends MetaParameters
 
     /**
      * CreateMeetingParameters constructor.
-     *
-     * @param mixed $meetingId
-     * @param mixed $meetingName
      */
-    public function __construct($meetingId = null, $meetingName = null)
+    public function __construct(string $meetingId, string $meetingName)
     {
         $this->meetingId   = $meetingId;
         $this->meetingName = $meetingName;
@@ -609,12 +606,9 @@ public function isVirtualBackgroundsDisabled(): ?bool
      * Default: false
      *
      * @since 2.4.3
-     *
-     * @param mixed $virtualBackgroundsDisabled
-     *
      * @deprecated Removed in 2.5, temporarily still handled, please transition to disabledFeatures.
      */
-    public function setVirtualBackgroundsDisabled($virtualBackgroundsDisabled): self
+    public function setVirtualBackgroundsDisabled(bool $virtualBackgroundsDisabled): self
     {
         $this->virtualBackgroundsDisabled = $virtualBackgroundsDisabled;
 
@@ -998,10 +992,7 @@ public function setEndCallbackUrl($endCallbackUrl): self
         return $this;
     }
 
-    /**
-     * @param mixed $recordingReadyCallbackUrl
-     */
-    public function setRecordingReadyCallbackUrl($recordingReadyCallbackUrl): self
+    public function setRecordingReadyCallbackUrl(string $recordingReadyCallbackUrl): self
     {
         $this->addMeta('bbb-recording-ready-url', $recordingReadyCallbackUrl);
 
@@ -1102,11 +1093,9 @@ public function isBreakoutRoomsEnabled(): ?bool
      *
      * Default: true
      *
-     * @param mixed $breakoutRoomsEnabled
-     *
      * @deprecated Removed in 2.5, temporarily still handled, please transition to disabledFeatures.
      */
-    public function setBreakoutRoomsEnabled($breakoutRoomsEnabled): self
+    public function setBreakoutRoomsEnabled(bool $breakoutRoomsEnabled): self
     {
         $this->breakoutRoomsEnabled = $breakoutRoomsEnabled;
 
@@ -1195,10 +1184,8 @@ public function isAllowRequestsWithoutSession(): ?bool
      * Default: false
      *
      * @since 2.4.3
-     *
-     * @param mixed $allowRequestsWithoutSession
      */
-    public function setAllowRequestsWithoutSession($allowRequestsWithoutSession): self
+    public function setAllowRequestsWithoutSession(bool $allowRequestsWithoutSession): self
     {
         $this->allowRequestsWithoutSession = $allowRequestsWithoutSession;
 
@@ -1447,11 +1434,9 @@ public function getBreakoutRoomsGroups(): array
     }
 
     /**
-     * @param mixed $id
-     * @param mixed $name
-     * @param mixed $roster
+     * @param array<int, string> $roster
      */
-    public function addBreakoutRoomsGroup($id, $name, $roster): self
+    public function addBreakoutRoomsGroup(mixed $id, string $name, array $roster): self
     {
         $this->breakoutRoomsGroups[] = ['id' => $id, 'name' => $name, 'roster' => $roster];
 

src/Parameters/DeleteRecordingsParameters.php

@@ -27,9 +27,9 @@
  */
 class DeleteRecordingsParameters extends BaseParameters
 {
-    private ?string $recordingId = null;
+    private string $recordingId;
 
-    public function __construct(?string $recordingId = null)
+    public function __construct(string $recordingId)
     {
         $this->recordingId = $recordingId;
     }
@@ -40,7 +40,7 @@ public function getRecordingId(): ?string
         return $this->recordingId;
     }
 
-    public function setRecordingId(string $recordingId): DeleteRecordingsParameters
+    public function setRecordingId(string $recordingId): self
     {
         $this->recordingId = $recordingId;
 

src/Parameters/EndMeetingParameters.php

@@ -27,14 +27,16 @@
  */
 class EndMeetingParameters extends BaseParameters
 {
-    private ?string $meetingId = null;
+    private string $meetingId;
 
     /**
+     * The password of the moderator.
+     *
      * @deprecated
      */
-    private ?string $password = null;
+    private ?string $password;
 
-    public function __construct(?string $meetingId = null, ?string $password = null)
+    public function __construct(string $meetingId, ?string $password = null)
     {
         $this->password  = $password;
         $this->meetingId = $meetingId;
@@ -65,7 +67,7 @@ public function getPassword(): ?string
     /**
      * @deprecated
      */
-    public function setPassword(string $password): self
+    public function setPassword(?string $password): self
     {
         $this->password = $password;
 

src/Parameters/GetMeetingInfoParameters.php

@@ -27,13 +27,13 @@
  */
 class GetMeetingInfoParameters extends BaseParameters
 {
-    private ?string $meetingId = null;
+    private string $meetingId;
 
     private ?int $offset = null;
 
     private ?int $limit = null;
 
-    public function __construct(?string $meetingId = null)
+    public function __construct(string $meetingId)
     {
         $this->meetingId = $meetingId;
     }
@@ -57,7 +57,7 @@ public function getOffset(): ?int
         return $this->offset;
     }
 
-    public function setOffset(int $offset): self
+    public function setOffset(?int $offset): self
     {
         $this->offset = $offset;
 
@@ -70,7 +70,7 @@ public function getLimit(): ?int
         return $this->limit;
     }
 
-    public function setLimit(int $limit): self
+    public function setLimit(?int $limit): self
     {
         $this->limit = $limit;
 

src/Parameters/GetRecordingTextTracksParameters.php

@@ -27,12 +27,12 @@
  */
 class GetRecordingTextTracksParameters extends MetaParameters
 {
-    private ?string $recordId = null;
+    private string $recordId;
 
     /**
      * GetRecordingTextTracksParameters constructor.
      */
-    public function __construct(?string $recordId = null)
+    public function __construct(string $recordId)
     {
         $this->recordId = $recordId;
     }

src/Parameters/InsertDocumentParameters.php

@@ -29,9 +29,9 @@ class InsertDocumentParameters extends BaseParameters
 {
     use DocumentableTrait;
 
-    private ?string $meetingId = null;
+    private string $meetingId;
 
-    public function __construct(?string $meetingId = null)
+    public function __construct(string $meetingId)
     {
         $this->meetingId = $meetingId;
     }

src/Parameters/IsMeetingRunningParameters.php

@@ -27,9 +27,9 @@
  */
 class IsMeetingRunningParameters extends BaseParameters
 {
-    private ?string $meetingId = null;
+    private string $meetingId;
 
-    public function __construct(?string $meetingId = null)
+    public function __construct(string $meetingId)
     {
         $this->meetingId = $meetingId;
     }

src/Parameters/JoinMeetingParameters.php

@@ -28,9 +28,9 @@
  */
 class JoinMeetingParameters extends UserDataParameters
 {
-    private ?string $meetingId;
+    private string $meetingId;
 
-    private ?string $username;
+    private string $username;
 
     /**
      * @deprecated Password-string replaced by an Enum\Role-constant in JoinMeetingParameters::__construct()
@@ -50,7 +50,7 @@ class JoinMeetingParameters extends UserDataParameters
     /**
      * @var array<string, string>
      */
-    private array $customParameters;
+    private array $customParameters = [];
 
     private ?string $role = null;
 
@@ -60,12 +60,7 @@ class JoinMeetingParameters extends UserDataParameters
 
     private ?string $defaultLayout = null;
 
-    /**
-     * @param mixed $passwordOrRole
-     * @param mixed $meetingId
-     * @param mixed $username
-     */
-    public function __construct($meetingId = null, $username = null, $passwordOrRole = null)
+    public function __construct(string $meetingId, string $username, string $passwordOrRole)
     {
         $this->meetingId = $meetingId;
         $this->username  = $username;
@@ -75,7 +70,6 @@ public function __construct($meetingId = null, $username = null, $passwordOrRole
         } else {
             $this->password = $passwordOrRole;
         }
-        $this->customParameters = [];
     }
 
     #[ApiParameterMapper(attributeName: 'meetingID')]
@@ -84,7 +78,7 @@ public function getMeetingId(): ?string
         return $this->meetingId;
     }
 
-    public function setMeetingId(string $meetingId): JoinMeetingParameters
+    public function setMeetingId(string $meetingId): self
     {
         $this->meetingId = $meetingId;
 
@@ -116,7 +110,7 @@ public function getPassword(): ?string
     /**
      *@deprecated Password-string replaced by an Enum\Role-constant in JoinMeetingParameters::__construct()
      */
-    public function setPassword(string $password): self
+    public function setPassword(?string $password): self
     {
         $this->password = $password;
 
@@ -255,7 +249,7 @@ public function getHTTPQuery(): string
             $queries[$key] = $value;
         }
 
-        $queries = $this->buildUserData($queries);
+        $this->buildUserData($queries);
 
         return $this->buildHTTPQuery($queries);
     }

src/Parameters/PublishRecordingsParameters.php

@@ -27,11 +27,11 @@
  */
 class PublishRecordingsParameters extends BaseParameters
 {
-    private ?string $recordingId = null;
+    private string $recordingId;
 
-    private ?bool $publish = null;
+    private bool $publish;
 
-    public function __construct(string $recordingId, ?bool $publish = null)
+    public function __construct(string $recordingId, bool $publish)
     {
         $this->recordingId = $recordingId;
         $this->publish     = $publish;
@@ -71,7 +71,7 @@ public function toArray(): array
     {
         return [
             'recordID' => $this->recordingId,
-            'publish'  => !is_null($this->publish) ? ($this->publish ? 'true' : 'false') : $this->publish,
+            'publish'  => $this->publish ? 'true' : 'false',
         ];
     }
 }

src/Parameters/PutRecordingTextTrackParameters.php

@@ -27,18 +27,18 @@
  */
 class PutRecordingTextTrackParameters extends BaseParameters
 {
-    private ?string $recordId = null;
+    private string $recordId;
 
-    private ?string $kind = null;
+    private string $kind;
 
-    private ?string $lang = null;
+    private string $lang;
 
-    private ?string $label = null;
+    private string $label;
 
     /**
      * PutRecordingTextTrackParameters constructor.
      */
-    public function __construct(?string $recordId = null, ?string $kind = null, ?string $lang = null, ?string $label = null)
+    public function __construct(string $recordId, string $kind, string $lang, string $label)
     {
         $this->recordId = $recordId;
         $this->kind     = $kind;

src/Parameters/UpdateRecordingsParameters.php

@@ -27,9 +27,9 @@
  */
 class UpdateRecordingsParameters extends MetaParameters
 {
-    private ?string $recordingId = null;
+    private string $recordingId;
 
-    public function __construct(?string $recordingId = null)
+    public function __construct(string $recordingId)
     {
         $this->recordingId = $recordingId;
     }