Conversation
Write updated rendering code for all the polygonal geo shapes, which can share a substantial amount of code between all of the shapes (the only difference between shapes is the list of shape vertices). To allow using class inheritance for this, some of the abstract base classes (protocols) had to be re-arranged to avoid import loops. The missing octagon, pentagon, and rhombus-2 shapes are also implemented since they were trivial to add.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently fixes just the polygonal geo shapes, see the comment on db1dd29
WIP untested code. I expect to be doing more refactoring before this is ready to be merged.
Fixes #66, #72