Skip to content

Conversation

@ragusa87
Copy link
Collaborator

@ragusa87 ragusa87 commented Feb 21, 2025

  • multi search for same collection + TEST multi search raw
  • Union search (To be continued, especially naming and tests)
  • test multi search for same collection (SearchCollection > multisearchRaw + multisearch)
  • multi search for different collection + hydrated + tests => Second mr
  • Merge HydrateUnion with HydrateSearchResult and rename the class.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Coverage report for commit: 91c53ca
File: tests/coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.8%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.4%
  70% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.8%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.4%
  90% │ ████░░░░░░░░░░░░░░░░░░░ │ 11.1%
 100% │ ███████████████████████ │ 80.6%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution / ▒ = Previous Distribution
Summary - Lines: 89.48% 🔼 | Methods: 76.24% 🔽
FilesLinesMethodsBranches
src
   AbstractBiblioverseTypesenseBundle.php100.00%100.00%100.00%
   BiblioverseTypesenseBundle.php100.00%100.00%100.00%
src/Client
   ClientAdapter.php92.31%92.31%100.00%
   ClientInterface.php100.00%100.00%100.00%
   ClientSingletonFactory.php92.86%60.00%100.00%
src/CollectionAlias
   AliasException.php100.00%100.00%100.00%
   CollectionAlias.php100.00%100.00%100.00%
   CollectionAliasInterface.php100.00%100.00%100.00%
src/Command
   TypesensePopulateCommand.php98.04%75.00%100.00%
src/EventSubscriber
   IndexCollectionSubscriber.php100.00%100.00%100.00%
src/Exception
   SearchException.php100.00%100.00%100.00%
src/Indexer
   Indexer.php100.00%100.00%100.00%
   IndexerInterface.php100.00%100.00%100.00%
src/Mapper
   CollectionManagerInterface.php100.00%100.00%100.00%
   DataGeneratorInterface.php100.00%100.00%100.00%
   MappingGeneratorInterface.php100.00%100.00%100.00%
   StandaloneCollectionManagerInterface.php100.00%100.00%100.00%
src/Mapper/Converter/Exception
   ValueConversionException.php60.00%66.67%100.00%
   ValueExtractorException.php100.00%100.00%100.00%
src/Mapper/Converter/Field
   FieldConverterInterface.php100.00%100.00%100.00%
src/Mapper/Converter
   ToTypesenseInterface.php100.00%100.00%100.00%
   ValueConverter.php91.53%25.00%100.00%
   ValueConverterInterface.php100.00%100.00%100.00%
   ValueExtractor.php94.44%66.67%100.00%
   ValueExtractorInterface.php100.00%100.00%100.00%
src/Mapper/Entity
   AbstractEntityDataGenerator.php100.00%100.00%100.00%
   EntityCollectionManagerInterface.php100.00%100.00%100.00%
   EntityDataGenerator.php100.00%100.00%100.00%
   EntityMapperGenerator.php100.00%100.00%100.00%
   EntityTransformer.php91.67%66.67%100.00%
   EntityTransformerInterface.php100.00%100.00%100.00%
src/Mapper/Entity/Identifier
   EntityIdentifier.php88.89%50.00%100.00%
   EntityIdentifierInterface.php100.00%100.00%100.00%
src/Mapper/Fields
   FieldMapping.php98.28%91.67%100.00%
   FieldMappingInterface.php100.00%100.00%100.00%
src/Mapper/Locator
   InvalidTypeMapperException.php100.00%100.00%100.00%
   MapperLocator.php89.58%50.00%100.00%
   MapperLocatorInterface.php100.00%100.00%100.00%
src/Mapper/Mapping
   Mapping.php100.00%100.00%100.00%
   MappingInterface.php100.00%100.00%100.00%
src/Mapper/Metadata
   MetadataMapping.php100.00%100.00%100.00%
   MetadataMappingInterface.php100.00%100.00%100.00%
src/Mapper/Options
   CollectionOptions.php100.00%100.00%100.00%
   CollectionOptionsInterface.php100.00%100.00%100.00%
src/Populate
   BatchGenerator.php100.00%100.00%100.00%
   PopulateService.php89.66%71.43%100.00%
src/Populate/WaitFor
   AbstractWaitForService.php100.00%100.00%100.00%
   WaitForDatabaseService.php100.00%100.00%100.00%
   WaitForInterface.php100.00%100.00%100.00%
   WaitForTypesenseService.php100.00%100.00%100.00%
src/Query
   SearchQuery.php80.85%12.50%100.00%
   SearchQueryInterface.php100.00%100.00%100.00%
   SearchQueryWithCollectionInterface.php100.00%100.00%100.00%
   SearchQueryWithWithCollectionAdapter.php100.00%100.00%100.00%
   VectorQuery.php95.45%66.67%100.00%
   VectorQueryInterface.php100.00%100.00%100.00%
   VoiceQueryInterface.php100.00%100.00%100.00%
src/Search/Hydrate
   HydrateRepositoryInterface.php100.00%100.00%100.00%
   HydrateSearchResult.php65.00%25.00%100.00%
   HydrateSearchResultInterface.php100.00%100.00%100.00%
   HydrateUnion.php--100.00%
src/Search/Results
   AbstractSearchResults.php98.21%92.31%100.00%
   SearchResults.php100.00%100.00%100.00%
   SearchResultsHydrated.php100.00%100.00%100.00%
src/Search
   Search.php65.22%25.00%100.00%
   SearchCollection.php--100.00%
   SearchCollectionInterface.php100.00%100.00%100.00%
   SearchInterface.php100.00%100.00%100.00%
src/Type
   DataTypeEnum.php100.00%100.00%100.00%
   FacetStrategyEnum.php100.00%100.00%100.00%
   InfixEnum.php100.00%100.00%100.00%
src/Utils
   ArrayAccessTrait.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@ragusa87 ragusa87 marked this pull request as draft February 21, 2025 18:03
@ragusa87 ragusa87 self-assigned this Feb 21, 2025
@ragusa87 ragusa87 force-pushed the multisearch branch 3 times, most recently from a39d9b2 to 31e435f Compare February 23, 2025 18:34
@ragusa87 ragusa87 force-pushed the main branch 3 times, most recently from f7d4606 to d3f214c Compare February 25, 2025 22:20
@ragusa87 ragusa87 force-pushed the multisearch branch 2 times, most recently from b52c77e to f37f9df Compare February 25, 2025 22:27
@ragusa87 ragusa87 force-pushed the main branch 2 times, most recently from a2dee81 to a8ce02c Compare February 25, 2025 22:31
BREAKING CHANGE: Search->search take SearchQueryInterface instead of
SearchQuery as argument
BREAKING CHANGE: SearchCollectionInterface must implement multisearch
and multisearchRaw
BREAKING CHANGE: SearchInterface must implement multiSearch # Please enter the commit message for your changes. Lines starting
@ragusa87 ragusa87 changed the title feat(multisearch): Multisearch for same collection support feat(multisearch): Multisearch with union search support Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants