feat: add support for BMP RFCs 9515, 9736, and 9972#286
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 89.66% 89.69% +0.02%
==========================================
Files 86 86
Lines 18289 18334 +45
==========================================
+ Hits 16399 16444 +45
Misses 1890 1890 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for recent BMP RFC updates by expanding BMP statistics type coverage (RFC 9972), separating Peer Up vs Initiation TLV namespaces and making TLV parsing forward-compatible (RFC 9736), and updating RFC support documentation (RFC 9515/9736/9972).
Changes:
- Add new
StatTypevariants for advanced Adj-RIB-In/Adj-RIB-Out monitoring statistics (RFC 9972). - Split Initiation vs Peer Up TLV namespaces and switch TLV parsing to
FromPrimitive+ catch-all to tolerate unknown TLVs (RFC 9736). - Update crate/docs RFC support list (RFC 9515, 9736, 9972).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/parser/bmp/messages/stats_report.rs |
Adds new BMP statistics type enum variants for RFC 9972. |
src/parser/bmp/messages/peer_up_notification.rs |
Introduces independent Peer Up TLV namespace + unknown-type handling (RFC 9736). |
src/parser/bmp/messages/initiation_message.rs |
Updates Initiation TLV namespace + unknown-type handling (RFC 9736). |
src/parser/bmp/error.rs |
Removes now-unused error conversions tied to TryFromPrimitive TLV parsing. |
src/lib.rs |
Updates RFC support documentation list. |
README.md |
Updates RFC support documentation list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- RFC 9515: administrative registration procedures update (docs only) - RFC 9736: separate Peer Up TLV namespace from Initiation TLVs; switch to FromPrimitive with catch-all for forward compatibility - RFC 9972: add 26 new StatType variants for Adj-RIB-In/Adj-RIB-Out monitoring statistics
digizeph
force-pushed
the
feature/bmp-rfcs-9515-9736-9972
branch
from
e9bf17c to
31e5c36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for three recent BMP-related RFCs:
All changes are backward-compatible. Unknown TLV types are now gracefully handled per RFC 7854.