QA: Add log level guards for logger.error statements#8
Open
melisaadakli wants to merge 3 commits intobezkoder:masterfrom
Open
QA: Add log level guards for logger.error statements#8melisaadakli wants to merge 3 commits intobezkoder:masterfrom
melisaadakli wants to merge 3 commits intobezkoder:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses GuardLogStatement issues identified via static analysis (CodeFlow).
Logger.error calls are now protected with log-level checks to prevent unnecessary
message construction when error logging is disabled.
Converted MavenWrapperDownloader into a proper utility class
by adding a private constructor to prevent instantiation.
No functional or business logic changes were introduced.
Static Analysis Impact (CodeFlow)
📉 CodeFlow results:
Known / Accepted Issues
SpringBootLoginExampleApplicationis flagged by static analysisas UseUtilityClass, however this is an expected and acceptable
pattern for Spring Boot entry-point classes.
This demonstrates a QA-driven improvement focusing on code quality, resource safety, and logging best practices.