Semantic and stylistic upgrade #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashes, commas and operators
…s and adds necessary ones for magic comments and method definitions
…s, parentheses, percents and opts for mutable constants, compact hash methods and directory path expansion
… rescue errors alignment
…mutable by default in preparation for Ruby 3
…sion to 2.5.8 which is in maintenance mode and should be the lowest secure version available
Contributor
|
Library function not affected. Works as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the project and addresses style issues based on the Ruby Style guide and Rubocop. It additionally adds versioning to gem dependencies and sets the default ruby version to 2.5.8 which is the minimum secure version recommended for projects currently.
The internal structure and API has not been altered in a way and should still work as normal.