-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
BRP requests without params are rejected, even for paramless methods #23643
Copy link
Copy link
Closed
Labels
A-Dev-ToolsTools used to debug Bevy applications.Tools used to debug Bevy applications.C-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesP-RegressionFunctionality that used to work but no longer does. Add a test for this!Functionality that used to work but no longer does. Add a test for this!S-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Metadata
Metadata
Assignees
Labels
A-Dev-ToolsTools used to debug Bevy applications.Tools used to debug Bevy applications.C-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesP-RegressionFunctionality that used to work but no longer does. Add a test for this!Functionality that used to work but no longer does. Add a test for this!S-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Bevy version and features
mainat commit53ddd5e615ae15ad796b36724ddd67516bec0c84.crates/bevy_remote.What you did
I sent a BRP request over HTTP to a method that does not need any params, for example
rpc.discover(other methods are affected as well), without including aparamsfield:What went wrong
paramsfield is missing:{ "jsonrpc": "2.0", "id": 0, "error": { "code": -32600, "message": "missing field `params`" } }This is a regression. The documentation states:
Additional information
Passing
params: nullworks:This is likely a result of the recent PR #23175 that introduced a custom (de)serializer for
BrpRequest.