[Merged by Bors] - 0.8 Migration guide#389
Closed
IceSentry wants to merge 51 commits into
Closed
Conversation
Contributor
|
task pools changing to a global is probably a breaking change, but PR wasn't labeled as such |
Member
|
Helping sort out confusion caused by changes to camera bundles from bevyengine/bevy#4745. This deserves top billing in terms of this version's migration guide. |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
nicopap
reviewed
Jul 15, 2022
frewsxcv
reviewed
Jul 15, 2022
nicopap
reviewed
Jul 15, 2022
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
nicopap
reviewed
Jul 15, 2022
nicopap
reviewed
Jul 15, 2022
rparrett
reviewed
Jul 22, 2022
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
Did a quick pass on the 0.8 code blocks for compilability.
Co-authored-by: Rob Parrett <robparrett@gmail.com>
rparrett
reviewed
Jul 22, 2022
Contributor
|
The section in the migration guide for your PR bevyengine/bevy#5210 could probably use some work, but I don't understand reflection enough to help. It's currently just using the Would you mind helping out here? |
rparrett
reviewed
Jul 23, 2022
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
Did a pass on the code blocks with the goal of formatting them consistently
Co-authored-by: Rob Parrett <robparrett@gmail.com>
Co-authored-by: Rob Parrett <robparrett@gmail.com>
rparrett
reviewed
Jul 23, 2022
afonsolage
reviewed
Jul 23, 2022
Contributor
afonsolage
left a comment
afonsolage
left a comment
There was a problem hiding this comment.
@rparrett sure, I'm not native, so I may not find the correct words to have a good migration guide, but here is what this PR does with more details
Member
|
Added some content in a PR: IceSentry#4 |
ndarilek
reviewed
Jul 26, 2022
ndarilek
reviewed
Jul 26, 2022
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
komadori
reviewed
Jul 27, 2022
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Jul 30, 2022
## Objective - Migration guide for 0.8 ## Solution - Create a new section for each PR tagged with `C-Breaking-Change` - Copy the Migration Guide from the PR if it exists - Create a few more sections for PR not tagged with the label ## Notes The ordering was pretty much whatever order github gave me when I searched breaking changes, so if you feel like something should be close to the top please notify me. For example, I moved the camera driven stuff at the top since it's probably going to be the biggest one Co-authored-by: Charles <IceSentry@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
C-Breaking-ChangeNotes
The ordering was pretty much whatever order github gave me when I searched breaking changes, so if you feel like something should be close to the top please notify me. For example, I moved the camera driven stuff at the top since it's probably going to be the biggest one