Spoiler math output when source message contains spoilers#12
Open
lethalNeutrino wants to merge 3 commits into
Open
Spoiler math output when source message contains spoilers#12lethalNeutrino wants to merge 3 commits into
lethalNeutrino wants to merge 3 commits into
Conversation
If the source message contains any Discord spoiler syntax (||text||), the rendered math image(s) will be sent with spoiler=True so they appear blurred until the viewer clicks to reveal. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Strip code block (```...```) and inline code (`...`) regions from message content before searching for spoiler patterns. This prevents false positives when || (norm notation) appears inside code blocks. Co-Authored-By: Andrew Liu <landrew7363@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…locks When a code block is directly wrapped in spoiler tags (e.g. ||<code>||), stripping code to empty string left |||| which SPOILER_RE couldn't match. Replacing with a space preserves the spoiler structure (|| ||). Co-Authored-By: Andrew Liu <landrew7363@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
||text||), the rendered math image(s) are sent as spoiler attachments (blurred until clicked)SPOILER_REregex to detect spoiler tags in the original message contentspoilerflag throughprocess_math->MathView->discord.File$...$auto-detection, ```tex code blocks, and!tex/`!typst` commandsTest plan
||$x^2$||and verify the output image is spoilered$x^2$and verify the output is not spoileredGenerated with Devin