Skip to content

Conversation

@eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Sep 19, 2025

Currently, on the main branch, the map web page is not loading (screenshot in #111). That's because the data it is fetching is in a different format than the web page was written to parse (the data is in the new "array of Entitys" format, whereas the web page was written to parse the "array of thingies" format the BERtron hackathon members had come up with a few months ago).

On this branch, I updated the web page to parse that data in a way that works with the new format. I expect to do something similar for the other "data sources" (e.g. NMDC, JGI) once their JSON files get updated.

Fixes #111

@eecavanna eecavanna self-assigned this Sep 19, 2025
@eecavanna eecavanna requested a review from Copilot September 19, 2025 03:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the MONet data parsing logic to handle the new "array of Entity" data format instead of the previous "array of thingies" format, fixing the broken map web page functionality.

  • Changed coordinate extraction to use the coordinates property from each entity object
  • Updated identifier and URL extraction to use standardized id and uri properties from entity objects
  • Modified comment to reflect the new BERtron entity-based data structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eecavanna eecavanna merged commit a89f6e4 into main Sep 19, 2025
1 check passed
@eecavanna eecavanna deleted the 111-map-web-page-reports-invalid-latitudelongitude-values-in-emsl-monet-data branch September 19, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map web page reports invalid latitude/longitude values in EMSL MONet data

2 participants