-
Notifications
You must be signed in to change notification settings - Fork 2
add 3 integration tests as first pass at tests for data_ingest.py in mongodb #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sierra-moxon - ingest_data.py has been moved to src |
|
Note that the test objects in tests/data/ may need to be updated for new schema |
|
FYI: Now that ber-data/bertron-schema#63 and ber-data/bertron-schema#65 have been merged in the schema repo, the sample data files there can be loaded into downstream projects (like this). |
|
updated test data according to the new schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds initial integration tests for the MongoDB data ingestion functionality, addressing issue #81. The tests validate the end-to-end processing of real sample data through the data ingestion pipeline.
- Adds three comprehensive integration tests that verify GeoJSON transformation, complex coordinate handling, and directory-level processing
- Updates test data files to provide more realistic and diverse sample data for testing
- Includes pytest-mock dependency for enhanced mocking capabilities
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_ingest_data.py | New integration test file with three comprehensive tests for data ingestion functionality |
| tests/test_api.py | Minor fix changing assertion from "name" to "description" field |
| tests/data/*.json | Updates to sample test data files to provide more realistic test scenarios |
| pyproject.toml | Adds pytest-mock dependency for test mocking capabilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@sierra-moxon - the test data have been updated with the newer schema (committed to main in #103) . You may need to update things to account for this. |
|
I see- merged into one .json file @shreddd ? |
fixes #81