Skip to content

Conversation

@sierra-moxon
Copy link
Contributor

@sierra-moxon sierra-moxon commented Sep 15, 2025

fixes #81

@shreddd
Copy link
Contributor

shreddd commented Sep 15, 2025

@sierra-moxon - ingest_data.py has been moved to src

@shreddd shreddd mentioned this pull request Sep 15, 2025
2 tasks
@shreddd
Copy link
Contributor

shreddd commented Sep 15, 2025

Note that the test objects in tests/data/ may need to be updated for new schema

@eecavanna
Copy link
Collaborator

FYI: Now that ber-data/bertron-schema#63 and ber-data/bertron-schema#65 have been merged in the schema repo, the sample data files there can be loaded into downstream projects (like this).

@sierra-moxon
Copy link
Contributor Author

updated test data according to the new schema.

@sierra-moxon sierra-moxon changed the title stub out new tests file for data_ingest.py in mongodb add 3 integration tests as first pass at tests for data_ingest.py in mongodb Sep 16, 2025
@sierra-moxon sierra-moxon marked this pull request as ready for review September 16, 2025 21:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds initial integration tests for the MongoDB data ingestion functionality, addressing issue #81. The tests validate the end-to-end processing of real sample data through the data ingestion pipeline.

  • Adds three comprehensive integration tests that verify GeoJSON transformation, complex coordinate handling, and directory-level processing
  • Updates test data files to provide more realistic and diverse sample data for testing
  • Includes pytest-mock dependency for enhanced mocking capabilities

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

File Description
tests/test_ingest_data.py New integration test file with three comprehensive tests for data ingestion functionality
tests/test_api.py Minor fix changing assertion from "name" to "description" field
tests/data/*.json Updates to sample test data files to provide more realistic test scenarios
pyproject.toml Adds pytest-mock dependency for test mocking capabilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sierra-moxon sierra-moxon removed the request for review from shreddd September 16, 2025 21:35
@shreddd
Copy link
Contributor

shreddd commented Sep 16, 2025

@sierra-moxon - the test data have been updated with the newer schema (committed to main in #103) . You may need to update things to account for this.

@sierra-moxon
Copy link
Contributor Author

sierra-moxon commented Sep 16, 2025

I see- merged into one .json file @shreddd ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for ingest

4 participants