feat(subject): list allowed scopes in unknown-scope error#99
Merged
Conversation
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
benner
force-pushed
the
feat/improve-error-messages
branch
from
788f9b2 to
c8dbab2
Compare
Most users hitting this don't know about -s. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Append the allowed list inline when the configured set is at most len(TYPES) (= 11, the default count) so users don't have to re-read docs to see what's valid; fall back to "see configured types" when the list is bigger than the default. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Same threshold as types — list inline when configured set is at most len(TYPES), else point at configuration. Reuses _format_allowed_hint. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
benner
force-pushed
the
feat/improve-error-messages
branch
from
c8dbab2 to
0db7f9d
Compare
benner
added a commit
that referenced
this pull request
May 6, 2026
The imperative line was hand-written (`want imperative verb` was never produced) and PR #99's signed-off hint never propagated. Real messages overflow 64ch, hence the widening. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same threshold as types — list inline when configured set is at most
len(TYPES), else point at configuration. Reuses _format_allowed_hint.