fix(ci): fail reviewdog jobs at any finding level#92
Merged
Conversation
-fail-on-error and the wrappers' fail_on_error: true map to fail_level=error, so only error-severity findings tripped the threshold. zizmor reported PR #91's pre-fix template-injection at a lower severity, which slipped through and merged. Move the manual reviewdog calls and the action-actionlint/action-markdownlint wrappers to fail_level=any so info and warning findings block too. Add set -o pipefail to the manual pipelines so an upstream tool crash isn't masked by a clean reviewdog exit. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-fail-on-error and the wrappers' fail_on_error: true map to
fail_level=error, so only error-severity findings tripped the
threshold. zizmor reported PR #91's pre-fix template-injection at a
lower severity, which slipped through and merged. Move the manual
reviewdog calls and the action-actionlint/action-markdownlint
wrappers to fail_level=any so info and warning findings block too.
Add set -o pipefail to the manual pipelines so an upstream tool
crash isn't masked by a clean reviewdog exit.