fix(config): exit cleanly on malformed .commit-guard.toml#88
Merged
Conversation
A syntax error in the config file used to surface as a raw TOMLDecodeError traceback at every invocation, including from the commit-msg hook where the user has nowhere to look. Other config-error paths already sys.exit with a friendly prefix; match that pattern and include the resolved file path so users with a stale config in a parent directory know which file to fix. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A syntax error in the config file used to surface as a raw
TOMLDecodeError traceback at every invocation, including from the
commit-msg hook where the user has nowhere to look. Other config-error
paths already sys.exit with a friendly prefix; match that pattern and
include the resolved file path so users with a stale config in a parent
directory know which file to fix.