feat(subject): make uppercase description check configurable#66
Merged
Conversation
Some projects legitimately allow uppercase descriptions. Add --no-require-lowercase CLI flag and require-lowercase config key (default: true) to opt out of the check without disabling the entire subject check. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
The trailing period was hardcoded. Replace it with a configurable set of forbidden trailing characters (no-trailing-chars, default ['.']), supporting any char including space. An empty set disables the check. Add --no-trailing-chars CLI flag, no-trailing-chars config key, and the corresponding action input. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.