ci(test): fix coverage comment for fork PRs via workflow_run split#64
Merged
Conversation
Fork PRs get a read-only token on pull_request, so the coverage comment was silently dropped. Split into two workflows following the GitHub Security Lab secure pattern: test.yml saves coverage.xml and the PR number as an artifact; coverage-comment.yml triggers on workflow_run with pull-requests: write to download the artifact and post the comment. https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PRs get a read-only token on pull_request, so the coverage comment
was silently dropped. Split into two workflows following the GitHub
Security Lab secure pattern: test.yml saves coverage.xml and the PR
number as an artifact; coverage-comment.yml triggers on workflow_run
with pull-requests: write to download the artifact and post the comment.
https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/