fix!: detect missing blank line separator in body check#61
Merged
Conversation
A two-line message (subject + body, no blank line) was hitting the len < 3 guard and reporting "missing body" instead of "missing blank line between subject and body". The body was present; only the separator was wrong. BREAKING CHANGE: the body check now emits "missing blank line between subject and body" instead of "missing body" when a non-blank second line immediately follows the subject. Scripts or CI steps that match on the exact error message string will need updating. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A two-line message (subject + body, no blank line) was hitting the
len < 3 guard and reporting "missing body" instead of "missing blank
line between subject and body". The body was present; only the
separator was wrong.
BREAKING CHANGE: the body check now emits "missing blank line between
subject and body" instead of "missing body" when a non-blank second
line immediately follows the subject. Scripts or CI steps that match
on the exact error message string will need updating.