feat: make maximum subject length configurable#27
Merged
Conversation
Decouples the function from the global MAX_SUBJECT_LEN constant so callers can pass a custom limit. Defaults to MAX_SUBJECT_LEN to preserve existing behaviour. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
The 72-character limit suits most projects but some (monorepos, tooling repos) benefit from a higher limit. --max-subject-length replaces the default when set, so projects can enforce the length that fits their convention. Supported via --max-subject-length CLI flag and max-subject-length key in .commit-guard.toml; CLI takes precedence over config. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 72-character limit suits most projects but some (monorepos, tooling
repos) benefit from a higher limit. --max-subject-length replaces the
default when set, so projects can enforce the length that fits their
convention.
Supported via --max-subject-length CLI flag and max-subject-length key
in .commit-guard.toml; CLI takes precedence over config.