test: add intentional ruff violation to verify github-pr-review reporter#25
Closed
benner wants to merge 1 commit into
Closed
test: add intentional ruff violation to verify github-pr-review reporter#25benner wants to merge 1 commit into
benner wants to merge 1 commit into
Conversation
benner
force-pushed
the
test/ruff-pr-review-reporter
branch
from
e85151a to
6be6cfb
Compare
benner
changed the title
benner
force-pushed
the
ci/ruff-reporter-github-pr-review
branch
from
8759bcb to
30c2294
Compare
Adds an unused variable in check_body to confirm the action posts inline review comments on the PR diff. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
benner
force-pushed
the
test/ruff-pr-review-reporter
branch
from
6be6cfb to
59e7939
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
|
|
||
| def check_body(lines, result): | ||
| separator = lines[1] if len(lines) > 1 else "" |
There was a problem hiding this comment.
[ruff] reported by reviewdog 🐶
F841 Local variable separator is assigned to but never used
Owner
Author
|
works as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an unused variable in check_body to confirm the action posts
inline review comments on the PR diff.