feat(signature): distinguish HTTP auth errors from network outages#102
Merged
Conversation
A rotated GITHUB_TOKEN previously surfaced as "GitHub API unreachable" because _resolve_github_username swallowed every Commits API HTTPError except 404, and the outer handler only knew URLError. Re-raise 401/403 from the Commits API and split HTTPError out of URLError so 401, 403, and other codes each get a distinct message. Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Coverage Report (Δ +0.0%)
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rotated GITHUB_TOKEN previously surfaced as "GitHub API unreachable"
because _resolve_github_username swallowed every Commits API HTTPError
except 404, and the outer handler only knew URLError. Re-raise 401/403
from the Commits API and split HTTPError out of URLError so 401, 403,
and other codes each get a distinct message.