add code style settings for jetbrain's products, add exception to json parser for GetNotificationPreferences #38
Conversation
.gitignore
Outdated
| npm-debug.log | ||
|
|
||
| .idea | ||
| !.idea/codeStyleSettings.xml |
There was a problem hiding this comment.
@1mike12 This seems like the kind of thing that belongs in your .gitignore_global file (run git config --get core.excludesfile for the path), not specific repos. Everyone uses a different editor and .gitignore files would get out of control of they had to accommodate everyone's setup.
(I also use Webstorm, FWIW, and have .idea in my ~/.global_gitignore.)
There was a problem hiding this comment.
no you're totally right, I wasn't thinking and rushed the push up. thanks for the tip
|
|
||
| if (key === "UserDeliveryPreferenceArray"){ | ||
| //add an exception for this since the ArrayName and Key name are incongruent | ||
| parentObj[newKey] = _.compact(parentObj[key][0]["NotificationEnable"]) |
There was a problem hiding this comment.
(I'm assuming this is for https://www.developer.ebay.com/Devzone/XML/docs/Reference/eBay/GetNotificationPreferences.html#Response.UserDeliveryPreferenceArray ?)
This seems reasonable enough. It's a shame this module has to have so much crazy parsing code, but it's mostly because the source data it's dealing with is often structured bizarrely.
There was a problem hiding this comment.
yeah it is. I think as gross as it is, if someone else wants to take a stab at it, then you gave them the option to make their own parser, and yes, it's ebay's fault for being so inconsistent.
benbuckman
left a comment
benbuckman
left a comment
There was a problem hiding this comment.
@1mike12 I'm inclined to merge the parsing change but not the .gitignore change for the reasons mentioned inline.
Please let me know if you disagree.
Thanks
…keys are named differently. fixes #37
2 participants
No description provided.