Conversation
mguludag
requested review from
JeffGarland,
camio,
ednolan and
inbal2l
as code owners
✅ Deploy Preview for bemanproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
idk if this really applys to this PR, but I believe this file is now out of date as the maturity model now includes the process to go to production ready
docs/beman_standard.md
Outdated
| ```markdown | ||
| **Implements**: [`std::optional<T&>` (P2988R5)](https://wg21.link/P2988R5) and | ||
| [Give *std::optional* Range Support (P3168R1)](https://wg21.link/P3168R1). | ||
| [Give _std::optional_ Range Support (P3168R1)](https://wg21.link/P3168R1). |
There was a problem hiding this comment.
The std::optional is for italic, but that isn't really what we want I think? We just want code font like this: std::optional?
There was a problem hiding this comment.
the formatter from linter changed it but I changed it to use double * and seems fine for the formatter
JeffGarland
left a comment
JeffGarland
left a comment
There was a problem hiding this comment.
I'm approving - this mostly seems like whitespace changes. I'm kinda clueless on some of the yaml, but I trust it's fine.
2 participants
#22 Add basic CI flows