allow checking formatting with cache#1830
Conversation
|
I think there's probably nothing to test here; it doesn't look like there were tests for the previous behaviour (and no tests for the CLI arguments in general as far as I can tell) |
belav
left a comment
There was a problem hiding this comment.
My worry with this change is that I had a commit to specifically disable the cache when running check, but I don't recall why I would have made that change and neglected to leave a comment explaining why.
It seems safer to have a new option for the check command --use-cache so that it can default to the current behavior.
|
I do think it's a little unfortunate to have a different API surface between checking and formatting but I made that change |
belav
left a comment
There was a problem hiding this comment.
Thanks for updating. I was thinking that running the check command in a GH action may have had issues with using the cache. That might be why I disabled it for the check command.
|
Thanks! I'm planning to try it out in CI so I'll report back if there are any issues. |
Description
I run csharpier check as part of my lint flow, which means I run it a lot. On one of my repositories it takes 200ms to run format and 8000ms to run check. This PR allows for
checkto use the cache (although it can be disabled, just like forformat)Related Issue
Checklist
varthis.