Support min_os_version on Windows#2855
Conversation
| app_packages_path: Path, | ||
| **kwargs, | ||
| ): | ||
| support_min_version = 10240 # Windows 10 |
There was a problem hiding this comment.
Hardcoded because there's no reliable way to detect the minimum version from the support package as far as I know.
There was a problem hiding this comment.
The support package won't include this information, but we could include it in the briefcase.toml in the app template - that is where the support package build number is defined, so it would make sense to tie the two together, rather than hard-coding the value here. If it isn't in the template, falling back to "not defined" would make sense to me.
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the update. This looks like a really useful improvement; a couple of suggestions inline regarding how this will be applied in practice.
| app_packages_path: Path, | ||
| **kwargs, | ||
| ): | ||
| support_min_version = 10240 # Windows 10 |
There was a problem hiding this comment.
The support package won't include this information, but we could include it in the briefcase.toml in the app template - that is where the support package build number is defined, so it would make sense to tie the two together, rather than hard-coding the value here. If it isn't in the template, falling back to "not defined" would make sense to me.
| "Your Windows app specifies a minimum build number of " | ||
| f"{min_version}, but the support package only supports " | ||
| f"{support_min_version}" | ||
| ) |
There was a problem hiding this comment.
This checks the value on the installer side, but it won't put the value into the template in the "default" case. i.e., it will catch the error if I try to build the app on Windows 8, but if I build the app on Windows 11, and then try to install on Windows 8, it won't pass that information down unless I explicitly put min_os_version in the app config.
2 participants
This adds support for specifying the minimum supported Windows build number using the
min_os_versionoption.PR Checklist:
Context
ankitects/anki#4765