Skip to content

Release/v4 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
beetlebugorg wants to merge 69 commits into
base: master
Choose a base branch
from
Draft

Release/v4 #52

beetlebugorg wants to merge 69 commits into from

Conversation

@beetlebugorg
Copy link
Owner

@beetlebugorg beetlebugorg commented Nov 10, 2024 •
edited
Loading

  • Upgrade to Imagemagick 7
  • Remove legacy code that was no longer in use
  • Reorganize code to ease maintenance

@beetlebugorg
Update .gitignore
5f598ef
@beetlebugorg
Update devcontainer dependencies
55974b0 
Apache 2.4.62
Imagemagick 7.1.1-40
libwebp 1.4.0
libtiff 1.7.0
@beetlebugorg
Replace use of ParseSizeGeometry
d9e85f3 
This was removed in Imagemagick 7.
@beetlebugorg
Update devcontainer.json
eb4876b
@beetlebugorg
Reorganize code
69ab918 
Starting to move code to separate files for better organization and to reduce the size of the mod_dims.c file.

No logic changes.
@beetlebugorg
Remove dims_sizer endpoint
90ba127
@beetlebugorg
Update version to 4.0.0alpha
31c35c0
@beetlebugorg
Move curl init/cleanup to curl.c|h
cadb2d8
@beetlebugorg
Remove support for local filesystem
0a12237
@beetlebugorg
Remove legacy dims support
f31555d
@beetlebugorg
Partial refactor of handler logic
f85945d 
The goal here is to split the dims3 and dims4 verification logic.
@beetlebugorg
Set PKG_CONFIG_PATH in devcontainer
7237a2c
@beetlebugorg
Add cpptools extension to devcontainer
18b113c
@beetlebugorg
Set includePath for VS Code
a819f26
@beetlebugorg
Set DIMS_SECRET to non-empty value
0256a7f
@beetlebugorg
Set IntelliSense compiler
bc32760
@beetlebugorg
Separate out dims3/dims4 request logic
4054541 
Also starting the process of cleaning up error handling with a goal of centralizing it in the handlers.
@beetlebugorg
Use Zig for build system rather than autoconf
130ab82
@beetlebugorg
Experimental zig build
1b1f006
@beetlebugorg
Remove examples/ directory
f0d41b7
@beetlebugorg
Rename license file
76cfd9f
@beetlebugorg
Fix build on macOS
90157c4
@beetlebugorg
Move Dockerfiles to the project root
f95569e
@beetlebugorg
Convert main Dockerfile to Alpine
69ffb76
@beetlebugorg
Use Alpine packages
c9462eb
@beetlebugorg
Add env file for local development
77487fe
@beetlebugorg
Fix case when _keys is empty
8ddf3dc
@beetlebugorg
Error handling clean, first pass
ba79ce0 
Removed dims_cleanup
@beetlebugorg
Update Dockerfile
74263f2
@beetlebugorg
Error handling clean, second pass
b72a0d0
@beetlebugorg
Preparse commands
6393b96 
The command string was being parsed in several different places in the code.

Now it's done up front during dims_request_rec setup.
@beetlebugorg
Simplify handler.c
82748dd 
This moves URL parsing logic into mod_dims.c leaving dims_handler() to do the bare minimum, call dims3, dims4, or dims-status.
@beetlebugorg
Name structs
b34b6ce
@beetlebugorg
Remove config methods for encoded fetch
be91ef4 
This is no longer used.
@beetlebugorg
Improve dims_send_image
57f6dae 
This method is mostly calculating cache headers.

Source image max-age parse logic was moved to source image loading.

The http status logic was moved to a method and is returned by dims_handle_request.
@beetlebugorg
Remove uptime from status
cff1694
@beetlebugorg
Improve dims_process_image
469b94a
@beetlebugorg
Fix segfault when no query params are set
a7a4601
@beetlebugorg
Free image/format after sending
468110f
@beetlebugorg
Update dims.conf to show notes usage
492876e
@beetlebugorg
Fix bug in downstream_ttl
12daef4 
This was introduced by the rewrite.
@beetlebugorg
Fix memory leak in dims_process_image
f171e32
@beetlebugorg
Remove optimizedResize feature
8b338cb
@beetlebugorg
Clean up logging
1de833b
@beetlebugorg
Replace imagemagick directives with envvars
07a4948 
Since Imagemagick can be configured by environment variables it's easier just use those as we're exposing them as-is anyway.

https://imagemagick.org/script/resources.php
@beetlebugorg
Replace "no_image" with error background color
38933d3
@beetlebugorg
Simplify error codes
abcd625
@beetlebugorg
Use curl_easy_header
d79147b 
This simplifies the header logic.

Requires curl 7.83.0 or newer.
@beetlebugorg
Remove unused url_encode method
99996b0
@beetlebugorg
Fix memory leaks in dims_send_error
1d2c101
@beetlebugorg
Remove zig ext from devcontainer
21119f5
@beetlebugorg
Fix env var name
cdb90d2
@beetlebugorg
Refactor dims_write_image_cb
67ea5e2
@beetlebugorg
Improve header parsing
f816f21
@beetlebugorg
Refactor dims_process_image
7721c0d 
Return an error rather than the image.
@beetlebugorg
Set d->wand to NULL after freeing
7ec1fa4
@beetlebugorg
Use local vars
a8306f9
@beetlebugorg
Use asserts to validate arguments
2e0ea79
@beetlebugorg
Explicitly check for NULL when fetching profiles
3869cdf
@beetlebugorg
Verify memory allocations succeed
2ae2454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beetlebugorg