Moved PytestPluginTestHelper class into test_helper.

[semohr]

This PR moved the PytestPluginTestHelper which was duplicated in quite a few test files into the beets/test/helper.py file.

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.44%. Comparing base (611a19a) to head (c08a5e5).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6658   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files         161      161           
  Lines       20710    20710           
  Branches     3276     3276           
=======================================
  Hits        15004    15004           
  Misses       4980     4980           
  Partials      726      726           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

PR move pytest helper mixin out of duplicated test files into shared beets/test/helper.py, and also modernize some plugin tests to use that helper + requests-mock based HTTP/image mocking.

Changes:

• Move PytestPluginTestHelper into beets/test/helper.py and switch plugin tests to import it.
• Add pytest-focused helpers (PytestTestHelper, ImageRequestMocker) and switch FetchImageHelper from responses to requests-mock.
• Refactor fetchart/embedart plugin tests to pytest fixtures + requests-mock style network mocking.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
beets/test/helper.py	Add shared pytest helpers (PytestTestHelper, PytestPluginTestHelper) and new requests-mock based image mocking helper.
test/plugins/test_mbsync.py	Remove local duplicated pytest helper class; import shared PytestPluginTestHelper.
test/plugins/test_hook.py	Remove local duplicated pytest helper class; import shared PytestPluginTestHelper.
test/plugins/test_embedart.py	Update embedart tests to use shared pytest helpers and image_request_mock fixture.
test/plugins/test_art.py	Big refactor of fetchart tests to pytest fixtures + requests-mock, plus new request blocking behavior.

Comments suppressed due to low confidence (1)

test/plugins/test_art.py:56

• grug see Settings subclass fetchart.FetchArtPlugin but custom __init__ not call FetchArtPlugin.__init__. that make object not real plugin (no config, no listener setup, no invariants). better keep this as plain settings holder (dataclass / SimpleNamespace) instead of inheriting plugin class, so future code not accidentally call plugin methods and explode.

class Settings(fetchart.FetchArtPlugin):
    """Used to pass settings to the ArtSources when the plugin isn't fully
    instantiated.
    """

    def __init__(self, **kwargs):
        for k, v in kwargs.items():
            setattr(self, k, v)

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[semohr]

As an fyi: We do not use deprecation warning here as this is very spammy when running tests.

[snejus]

Note that another PR that I've just merged defined a similar class in helper.py - you will want to remove it after rebase.

[semohr]

Hmm, which class do you mean?

[snejus]

Hmm, which class do you mean?

See line 420 in helper.py after rebase.