lastgenre: replace built-in genre list with improved hierarchy#6654
Open
spaceage64 wants to merge 1 commit into
Open
lastgenre: replace built-in genre list with improved hierarchy#6654spaceage64 wants to merge 1 commit into
spaceage64 wants to merge 1 commit into
Conversation
52931f4 to
dcc1a46
Compare
Member
|
@spaceage64 the tests are failing. @JOJ0 I'll leave this one to you! |
dcc1a46 to
b27c421
Compare
Contributor
Author
|
Thanks. Yes, I think the Proper Case is causing the tests to fail. In practice, it shouldn't cause issues though. I have made the list Proper Case so we no longer have to use very simplistic code to have beets do the Proper Case conversion. Please let me know if more input is required from my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current genre list is alright but not very extensive, and also contains some oddities.
Replaces genres-tree.yaml and genres.txt with a significantly expanded and restructured genre hierarchy.
Pop → Asian Pop → K-Pop, notasian → east asian → k-pop.Electronic → Electronic Dance Music → House → Hard House → UK Hard House → Scouse House → Pumping House → HardbassClassical → Asian Classical → East Asian Classical → Korean Classical → Korean Court → Jeong-ak → GagokFolk → Traditional Folk → European Folk → Balkan Folk → Greek Folk → Cretan Folk → RizitikaSources used:
Fixes #6628
To Do
I don't know if my PR is even appreciated, but a lack of extensive genre maintenance was bothering me personally. The default list seems to be based on some very old extraction of Wikipedia and isn't necessarily of high quality. So I put a lot of effort into building this for personal use and I thought I'd at least offer to share. Please let me know if anything more would be required from my side.