Skip to content

autobpm: Hide noisy '"BPM already exists" log#6480

Open
JOJ0 wants to merge 2 commits intomasterfrom
autobpm_hide_log
Open

autobpm: Hide noisy '"BPM already exists" log#6480
JOJ0 wants to merge 2 commits intomasterfrom
autobpm_hide_log

Conversation

@JOJ0
Copy link
Copy Markdown
Member

@JOJ0 JOJ0 commented Mar 31, 2026

Description

When batch bpm computing, the plugin's output is very noisy. This change moves "BPM alredy exists for item" logs to DEBUG level.

  • Documentation. (Added a note to the plugin docs Configuration section)
  • Changelog.
  • Tests.

@JOJ0 JOJ0 requested a review from a team as a code owner March 31, 2026 06:31
@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

path = item.filepath
if bpm := item.bpm:
self._log.info("BPM for {} already exists: {}", path, bpm)
self._log.debug("BPM for {} already exists: {}", path, bpm)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, my thinking behind making this an info log was that the plugin should report when it calculates the BPM or when it skips it at equal verbosity levels. Otherwise, a user may get confused why certain files matching their query are not 'picked up'.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @snejus here. fetchart and replaygain print out skipped items without -v. A quiet flag might be better here - fetchart already has this:

beets/beetsplug/fetchart.py

Lines 1522 to 1529 in 712bada

cmd.parser.add_option(
"-q",
"--quiet",
dest="quiet",
action="store_true",
default=False,
help="quiet mode: do not output albums that already have artwork",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants