Show filter-aware empty state when no goals match search #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When filtering goals in the gallery, if no goals match the search term, the app now shows a helpful message indicating that goals are hidden due to the filter, rather than the generic "You have no Beeminder goals" message. Fixes #604 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Wrap noGoalsLabel in a container view with 20pt horizontal insets for better visual appearance. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use the standard UICollectionView backgroundView property to display the empty state message. This is cleaner than managing a separate view in the stack and toggling visibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove the totalGoalsCount class variable and compute it directly where needed, simplifying the code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When the search keyboard is visible, a centered label would be hidden. Position it 100pt from the top instead so it remains visible. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use UILayoutGuide constrained to keyboardLayoutGuide to center the label in the available space above the keyboard. The label will automatically animate when the keyboard appears/disappears. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The container must be in the view hierarchy before we can constrain it to keyboardLayoutGuide. Set backgroundView first, then add the layout guide and constraints. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
krugerk
reviewed
Jan 7, 2026
|
|
||
| if self.filteredGoals.isEmpty { | ||
| self.noGoalsLabel.isHidden = false | ||
| self.collectionContainer.isHidden = true |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #604
Test plan
🤖 Generated with Claude Code