[BeEF] Fix bare 'rescue' in spec_helper.rb#3558
Open
mitre88 wants to merge 2 commits intobeefproject:masterfrom
Open
[BeEF] Fix bare 'rescue' in spec_helper.rb#3558mitre88 wants to merge 2 commits intobeefproject:masterfrom
mitre88 wants to merge 2 commits intobeefproject:masterfrom
Conversation
added 2 commits
April 30, 2026 20:08
- Wrap File.open in a context manager (block) instead of storing the file handle in a local variable - Move function definition and main logic inside the block to ensure proper cleanup - Fix potential file descriptor leak if an exception occurred before log_file.close was called
Replace bare 'rescue' with 'rescue StandardError' to avoid catching unexpected system-wide exceptions like NoMemoryError, SystemExit, and SecurityError. This is safer for cleanup code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bare
rescueclause inspec/spec_helper.rbthat catches all exceptions including system-exiting ones.Issue
The code at line 170 used a bare
rescue:Bare
rescueis equivalent torescue StandardErrorin Ruby 2.x+, but still catchesStandardErrorand its subclasses. This should only catch expected errors (likeErrno::ESRCHwhen the process doesn't exist), not system-level exceptions like:NoMemoryErrorSecurityErrorSystemExitFix
Changed to
rescue StandardErrorwhich is more explicit and documented intent. This still catches all expected errors while being intentional about what's being caught.