[feature] 60 slots backpack#132
Conversation
bcmpinc
left a comment
bcmpinc
left a comment
There was a problem hiding this comment.
My apologies for the late reply. I had taken a look at it earlier, but did not know how to politely tell you that this still needs a lot of work. The patch lacks branching logic that decides which upgrade is being purchased. That means there's still only one upgrade and it upgrades from 36 to 60. At least it would be if it worked.
Considering the goal was to create a second upgrade, there's a lot that still needs to be done (see my review for where to start). Furthermore the screen for the community bundles has not been updated. Another issue you will run into is that on some screens inventories are going to overlap even more, especially in the museum.
To be honest, forgetting the branching logic, makes me wonder if you have enough programming experience to write this update. It gives me the impression you may have used AI to write this patch for you. If that is indeed the case, then I'm afraid this will turn out to become a waste of both of our time.
| "SetBackpackSizeCommand": "Set the size of the player's backpack. This must be a multiple of 12", | ||
| "Purchase": "Purchase ({{cost}}g)", | ||
| "BackpackUpgrade": "Backpack Upgrade -- 60 slots", | ||
| "PremiumPack": "Premium Pack", |
There was a problem hiding this comment.
There needs to be a second line here for the name of the second upgrade.
| BackpackCostName: "Backpack cost", BackpackCostTooltip: "How much you have to pay to buy this backpack in the shop.", | ||
| "SetBackpackSizeCommand": "Set the size of the player's backpack. This must be a multiple of 12", | ||
| "Purchase": "Purchase ({{cost}}g)", | ||
| "BackpackUpgrade": "Backpack Upgrade -- 60 slots", |
There was a problem hiding this comment.
This probably should be changed to Backpack Upgrade -- {{slots}} slots and the code referencing this string updated accordingly.
| /** How much you have to pay to buy this backpack in the shop. (default = 50000).*/ | ||
| public int BackpackCost = 50000; | ||
| /** How much you have to pay to buy this backpack in the shop. (default = 100000).*/ | ||
| public int BackpackCost = 100000; |
There was a problem hiding this comment.
There need to be two lines here. One cost for the first upgrade, another for the second.
| } | ||
|
|
||
| static void buyBackpack() { | ||
| Game1.player.Money -= getBackpackCost(); |
There was a problem hiding this comment.
Here needs to be a branch to decide which new upgrade is being bought and how much it costs.
| code[2].operand = 104; | ||
| code[6].operand = 120; | ||
|
|
||
| // Change inventory from a 6x6 grid to a 7x7 grid. |
There was a problem hiding this comment.
This needs to be changed into an 8*8 grid to accommodate the 60 inventory slots in the community bundle menu. The image used for this needs to be updated as well.
2 participants
Expand the 48 slots with a second "buyable" backpack with 60 slots
many things broken as per email chat, backlog :