-
Notifications
You must be signed in to change notification settings - Fork 7
fix: pr close issue #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pr close issue #2571
Conversation
|
closing to test pr close |
|
looks like we have two actions doing the same thing
I think we should remove it from pr close of helpers , and keep it in crunchy action, since it is related to crunchy db but we have to see which repos are affected https://github.com/bcgov/quickstart-openshift/actions/runs/20530954808/job/58982150168 A thing to discuss with @DerekRoberts and proceed, parking and keeping these open and the related PR in here bcgov/action-crunchy#46 |
|
@mishraomp Agreed! Let's get this done. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses an issue in the pr-close GitHub Actions workflow by updating version references for two reusable workflows/actions. The first change updates the quickstart-openshift-helpers workflow to a proper version tag, while the second changes the action-crunchy reference to a branch name.
- Updates bcgov/quickstart-openshift-helpers workflow reference from commit SHA to version tag v1.0.1
- Updates bcgov/action-crunchy action reference from commit SHA to branch reference fix/pr-close-remove-user
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
https://github.com/bcgov/quickstart-openshift/actions/runs/20530060797/job/58980004440
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: