Conversation
Contributor
3rdmike
commented
Jan 28, 2026
3rdmike
commented
- Allow AND/OR logic in occupant tags search (default is now OR)
- FuzzyMatch is now case insensitive
- FuzzyMatch now prefer exact locality match over partial matches (Ganges now correctly maps to Ganges in Salt Spring Island)
- Add WYN as a road type
…cality matches over prefix matches
Contributor
Author
|
Merge private road changes too. This will make sure future private roads are labeled as private road in street prep. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the version from 4.5.2 to 4.5.3 and introduces bug fixes for fuzzy matching along with AND/OR logic support for occupant tags filtering. The changes improve geocoding accuracy by making fuzzy matching case-insensitive and prioritizing exact locality matches over partial matches. Additionally, it adds "Wye" as a valid street type and implements special handling for private road names.
Changes:
- Enhanced fuzzy matching to be case-insensitive and prioritize exact locality matches over partial matches
- Added AND/OR logic support for occupant tags search (default is OR)
- Added "Wye" as a valid street type (railway term for Y-shaped track junction)
- Implemented private road handling to use secondary street name when primary is "Private Rd"
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Version bump from 4.5.2 to 4.5.3 |
| ols-geocoder-web/pom.xml | Version bump to match parent |
| ols-geocoder-core/pom.xml | Version bump to match parent |
| ols-geocoder-process/pom.xml | Version bump to match parent |
| ols-geocoder-admin/pom.xml | Version bump to match parent |
| ols-geocoder-core/src/main/java/ca/bc/gov/ols/geocoder/api/GeocodeQuery.java | Added tagCondition parameter and AND/OR logic for occupant tags filtering |
| ols-geocoder-core/src/main/java/ca/bc/gov/ols/geocoder/Geocoder.java | Enhanced fuzzy matching with case-insensitive comparison and locality match prioritization |
| ols-geocoder-core/src/main/java/ca/bc/gov/ols/geocoder/GeocoderDataStore.java | Added "Wye" as a valid street type |
| ols-geocoder-process/src/main/java/ca/bc/gov/ols/streetprep/StreetPrep.java | Implemented private road detection and handling to prioritize secondary street names |
| ols-geocoder-process/src/main/java/ca/bc/gov/ols/siteloaderprep/RawStreetName.java | Added isPrivateRoad boolean field to track private road names |
| .gitignore | Added local_data directory and backup file pattern (*~) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
…codeQuery.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: 3rdmike <124401782+3rdmike@users.noreply.github.com>
…codeQuery.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove debug println statements from GeocodeQuery tag filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.