#5760 - Fixes View/Edit Online/Blended offering from bulk upload#5929
Merged
tiago-graf merged 5 commits intomainfrom Mar 24, 2026
Merged
#5760 - Fixes View/Edit Online/Blended offering from bulk upload#5929tiago-graf merged 5 commits intomainfrom
tiago-graf merged 5 commits intomainfrom
Conversation
tiago-graf
added
Form.io
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Education Program Offering API response to avoid returning null for radio-field values that can cause Form.io submissions (used by bulk upload offering forms) to crash.
Changes:
- Convert
onlineInstructionModeandisOnlineDurationSameAlwaysfromnulltoundefinedso they are omitted from JSON responses when not set. - Add inline documentation explaining why
nullmust be avoided for these radio fields. - Minor import reordering.
dheepak-aot
reviewed
Mar 23, 2026
Collaborator
|
Nice work. 2 minor comments. |
dheepak-aot
reviewed
Mar 23, 2026
dheepak-aot
reviewed
Mar 23, 2026
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
approved these changes
Mar 23, 2026
Collaborator
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Thanks for the changes and E2E test. Looks good.
E2E SIMS API Coverage Report
|
sh16011993
reviewed
Mar 24, 2026
Comment on lines
+410
to
+413
| // Null and empty strings are converted to undefined so these fields are | ||
| // absent from the JSON response when not set. | ||
| // Form.io radio components crash when the | ||
| // submission data contains null for a radio field value. |
sh16011993
approved these changes
Mar 24, 2026
Collaborator
sh16011993
left a comment
sh16011993
left a comment
There was a problem hiding this comment.
Nice work @tiago-graf 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the offering form for bulk upload items.
Root cause is that form.io radio components will crash when receiving null values, the fix applied converts null values to undefined.