fix: implement validation null safety to process data and _encrypting#254
Closed
SalatielMG wants to merge 1 commit intobcgit:masterfrom
Closed
fix: implement validation null safety to process data and _encrypting#254SalatielMG wants to merge 1 commit intobcgit:masterfrom
SalatielMG wants to merge 1 commit intobcgit:masterfrom
Conversation
Contributor
|
@SalatielMG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear pointycastle team,
Fix issue: 253 Error: Null check operator used on a null value; in PaddedBlockCipherImpl.process #253
I identified that the issue is due to the lack of null safety checks on lines 52, 53, 56, and 86. I have created this PR with a proposed solution for this problem, ensuring that the necessary null checks are implemented.
I would greatly appreciate it if you could review this PR for integration or improvement in a future release of the library.
Thank you for your attention and for the excellent work you do with pointycastle.
Best regards, Salatiel Montero.