Skip to content

Conversation

@hendrikebbers
Copy link

Suggestion to make the solution for #2246 more clear and add a way to place test data on a different folder (by using an ENV).

@peterdettman
Copy link
Collaborator

This comment from the PR suggests you may have mistaken user.dir for user.home:

If the env variable is not present the test data will be assumed in a bc-test-data folder in your user root dir.

user.dir is the directory Java was launched from, not your user root dir. The search process first looks there and then back up along the path. The intended simple config is to checkout bc-test-data as a sibling of bc-java; note that the same test data is also looked for by other BC projects by the same logic (e.g. bc-csharp and the FIPS and LTS versions) - it was previously included in all those projects separately.

I think adding a comment to this effect in the Building section is fine; I'm less keen on introducing an environment variable.

@hendrikebbers
Copy link
Author

Did the mistake first, realized it later but did not updated the comment ;D

@hendrikebbers
Copy link
Author

I'm fine with doing only the change in the README. But that should really be done since I felt into exactly that pitfall. I will update the PR based on your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants