feat: parse Insert from URL script step#192
Merged
Merged
Conversation
Add a dedicated handler for the "Insert from URL" step (id 160), whose URL parameter is wrapped in <Parameter type="URL"><URL autoEncode><Calculation> and was previously rendered as a "PARAMETER NOT PARSED" placeholder. The step is now rendered in FileMaker's option order: Select, With dialog, Target, URL, Verify SSL Certificates, cURL options. Select and Verify SSL Certificates are shown by name only when enabled (keyed by parameter id, so this also holds for localized exports), and the trailing cURL calculation is prefixed with "cURL options:". Fixes #191 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
15ffb3e to
6294b34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #191.
The "Insert from URL" step (id 160) wraps its URL parameter in
<Parameter type="URL"><URL autoEncode="…"><Calculation>…. There was nohandler for the
URLparameter type, so the step rendered a⚠️ PARAMETER "URL" NOT PARSED ⚠️placeholder and dropped the URL calc.This adds a dedicated
insert_from_urlstep module (mirroringinsert_text),dispatched from
sanitizer.rs, and registersInsertFromURL = 160in theScriptStepenum.Rendering
Fields are emitted in FileMaker's option order:
<Calculation>and rendered asURL: <calc>.type="Calculation") is prefixed withcURL options:.4096/268435456), so the behavior also holds for localized exports (e.g.Auswahl,SSL-Zertifikate verifizieren).autoEncodeattribute is intentionally not surfaced.Test plan
insert_from_url.rs(empty URL, full step, Select/Verify off)cargo test— 118 passingcargo clippy --all-targetsclean,cargo fmtapplied🤖 Generated with Claude Code